I appreciate the licenses folder but could you add that information to the readme as well? It's useful sometimes to gather all the information I need about a project in the "readme" at least for me, just the names of the licenses and the files they affect could work if it's not too much trouble, but even just naming the licenses works. Thank you! :)
Please don't post shallow dismissals like this to HN. Substantive critique is welcome. For example, if you told us specifically what you noticed in the code, and what weaknesses it has and why, then we would all learn something.
Looks like a comprehensive and mature personal toolbox, which one would accumulate over years of working on C projects. Not exactly easy to reuse due to the lack of documentation and other reasons, but totally worthy of sharing nonetheless. A very interesting read.
Which means you didn't really read the source code, this is not a collection of other available libraries. Boost ASIO is C++, this is a C library, they only share the name as they're both implementing async IO. Code in the libc/libm folder isn't a rip of from somewhere else.
You may want to read some code before making derogatory comments based on basic name collisions. asio doesn't imply boost, nor is there a single libm out there.
It's great that someone took the time to curate the list. But maybe it'd be better as one of those awesome-X style list of actual repos. With all of these libraries distributed as a mega-lib, it just seems like a bit of a junk drawer.
I haven't taken much time to read the source, but it might be a good idea to break some pieces off into their own repos, perhaps with a required 'tbox_core' type lib.
Otherwise it's...eminently useful, and boring in a good way.
I just cloned the repository build it and did some tests with asio_httpd (and found a possible memory leak/fragmentation), overall it's well designed and coded.
To build it I went to the xmake repository and through it also found this small and performant network library https://github.com/caikelun/libsvx .
Thank you for release this nice and util library !
The library looks neat but I'm horrified that he says "optimizates"... repeatedly. That is not a word. The word is "optimizes". The English pedant in me is having trouble getting past that.
Judging by the site and the readme, it makes sense to assume that English is not the author's native language... It would make more sense to judge by the quality of the universal language there (C) and not half the readme (which can be easily fixed with a PR).
The English section of the readme looks like it's a more-or-less literal translation of the Chinese section, so I think we can forgive a little spelling when it's clear his native language isn't English.
35 comments
[ 1.9 ms ] story [ 91.3 ms ] threadAnd will call them if some libc functions are not supported in the current toolchain.
Another rewrite of malloc() and string utils is not that useful.
Strange that they don't use trailing commas in aggregate initializers though.
It's the sort of thing one inevitably ends up with after enough C development, but this looks much more complete than average.
Seems the author has put together random available libs implementations and "branded" them. That's all.
Which implementations were used? Which versions? What are the changes done to them? Which backdoors were added? :)
It's like this: http://img.tyt.by/n/it/0e/a/91202j.jpg
What libs are these specifically?
That's just from reviewing front pages of github repo and official site.
You may want to read some code before making derogatory comments based on basic name collisions. asio doesn't imply boost, nor is there a single libm out there.
Otherwise it's...eminently useful, and boring in a good way.
Thank you for release this nice and util library !