Ask HN: Code review tools
We've been using Gitlab's merge request resolution/code review tool for as long as I've worked here (9 months). However, it seems like Gitlab has gone and broken a good workflow: previously, a line in the diff marked with a comment would be marked resolved whenever the next commit would touch that same line on the diff. Now the line has to manually be marked--I can see validity to this, but maybe I just don't like change.
Anyway, I'm just curious of any other code review tools (which don't send our code anywhere questionable) which allow for similar functionality. Please note, we're pretty sold on the Gitlab kool-aid for now, so switching off doesn't seem viable.
2 comments
[ 3.0 ms ] story [ 16.7 ms ] threadWhat you're describing is indeed a departure from previous behavior, but I think it is a change for the better, even if it may take a little bit of getting used to. You're not the only one who was surprised by it though, and it's being discussed in https://gitlab.com/gitlab-org/gitlab-ce/issues/21406 I've laid out my thoughts in a comment there.
Feel free to chime in; as always, we'd love to hear your input!