10 comments

[ 3.3 ms ] story [ 38.0 ms ] thread
Should put a disclaimer in the README that this package doesn't validate checksums. Doesn't make it useless, just something to be aware of before deciding to use it. For example, if you want to ensure that a user entered a valid Bitcoin address, validating the checksum goes a lot further than a simple regex.
Exactly. A bit surprising that such a rudimentary lib reaches HN frontpage...
Agreed. This library is literally a collection of regexes.
I just want to know why the author dropped the 'o'.
The bitcoin test coverage is thin. Can it validate legacy multisig? Segwit? Bech32?
It does not have enough check
It does not have enough check
(comment deleted)