Don't know if it's just me, but there's a tiny bit of jank right after clicking in Chrome, where it seems to lag, jump a few frames, and then pick up in the middle of a zoom. Normally I wouldn't nitpick, but when something claims to be "super smooth", I become ultimately nit-picky ;)
I'm on the same version as you, but I am seeing something similar. The profiler shows an 83ms frame (12fps) on the 4th frame of the animation. Looks like a Chrome issue, maybe hardware dependent.
Experiencing something similar in Firefox 62.0.2
Slight 'stutter' (lack of smoothness, jumping) when clicking to zoom into a 'box/tab' and then a full screen 'blink'/jump forward then back' when zooming out from a 'box/tab'.
It seems to be resolution dependent. Full screen on at 4K is like a slideshow (or janky) on my late 2017 mbp. With a smaller window it's pretty smooth.
I agree with others here, re: “Tab” … this is a grid.
Some improvements that would be cool to see:
* keyboard shortcuts (up, down, left, right & esc to exit)
* the arrows behave differently when using the up & down vs left & right, up & down repeats grid items in the same column while left & right seem to shift to the previous or next row depending on where you are
* there’s a lot of JS on the page (it’s not just toggling classNames), maybe using CSS Grid or Flex could reduce some of that
* the HTML could probably be more semantic, less div elements, and maybe an actual list (ul or ol element), which could help make use of arrows more consistent
Tested on firefox and chrome and the animation is inconsistently janky. Based on a quick overview of the source code I would suggest looking at requestAnimationFrame[0] to smooth out the problems. Other than that, looks interesting.
Yea I was hoping for that too; misread the title. :-P
It's still very well put together. It'd be nice if this were possible without Javascript, but I don't think it is. It'd require some crazy scroll tricks to pull off, if it's even possible.
GitHub hides all but the first few lines of any repository's README on their mobile site, and the "Demo" link here just happens to fall below the cutoff. Click the "View all of README.md" link to see the rest.
37 comments
[ 2.9 ms ] story [ 80.6 ms ] threadProfiler output: https://imgur.com/a/sjYQAJp
Some improvements that would be cool to see:
* keyboard shortcuts (up, down, left, right & esc to exit)
* the arrows behave differently when using the up & down vs left & right, up & down repeats grid items in the same column while left & right seem to shift to the previous or next row depending on where you are
* there’s a lot of JS on the page (it’s not just toggling classNames), maybe using CSS Grid or Flex could reduce some of that
* the HTML could probably be more semantic, less div elements, and maybe an actual list (ul or ol element), which could help make use of arrows more consistent
[0]: https://developer.mozilla.org/en-US/docs/Web/API/window/requ...
https://hg.mozilla.org/releases/mozilla-release/rev/7d280b7e...
Name: Firefox
Version: 61.0.1
Build ID: 20180704194802
OS: Linux 4.13.0-46-generic
Looks good though.
It's still very well put together. It'd be nice if this were possible without Javascript, but I don't think it is. It'd require some crazy scroll tricks to pull off, if it's even possible.
Edit: I see why now