I'm trying to figure out if the code is still active case, but this is a quite recent ticket (after the release of the Chromium-based edition, and updated 4 days ago)
Then link to the new repo and provide context. Just highlighting a line with absolutely no context is sensationalist. I'm sure there have been public discussions about this.
I'm sure there have been public discussions about this.
Can you substantiate this? Because that would be extremely relevant to the conversation. Making statements with absolutely no context just seems sensationalistic.
If you're sure that there's been public discussion about the matter, then surely you won't have to spend too much time looking it up on Google? Backing up assertions takes energy. Are you motivated enough to champion your own assertions?
Please understand the difference between an assumption and an assertion. I don't use Brave so there is zero motivation for me to dig into this issue. That's why my language expresses an assumption with the phrase "I'm sure".
> then surely you won't have to spend too much time looking it up on Google?
The more niche the topic, the harder it will be to find, even if it is publicly available.
> Are you motivated enough to champion your own assertions?
Now you're just being a twat. Why didn't you spend this energy contributing to the discussion by picking up where I left off and finding out if my assumption was correct? I guess it was easier to attempt to get some dopamine flowing by leveraging yourself into a superior position over someone on the internet.
The related commits are years old. This isn't new. Last commit to that line was 3 years ago with the comment "unblocking embedding of twitter timelines".
There's a balance between breaking the web and being as strict as possible. Saying we fully allow Facebook tracking isn't right [1], but we admittedly need more strict-mode like settings for privacy conscious users.
We do block Facebook at least as good as uBlock origin with EasyPrivacy. The referenced code is in a separate component which does the same as Disconnect blocking.
We're taking this seriously internally and we'll iterate on where we are to improve the situation. We're looking at if we can polyfill a local JS resource instead for example as one option if it doesn't make further requests.
27 comments
[ 3.6 ms ] story [ 72.7 ms ] threadThe whitelist is in both versions
I'm trying to figure out if the code is still active case, but this is a quite recent ticket (after the release of the Chromium-based edition, and updated 4 days ago)
> // Temporary whitelist until we find a better solution
This post is sensationalist, flagged.
Can you substantiate this? Because that would be extremely relevant to the conversation. Making statements with absolutely no context just seems sensationalistic.
> then surely you won't have to spend too much time looking it up on Google?
The more niche the topic, the harder it will be to find, even if it is publicly available.
> Are you motivated enough to champion your own assertions?
Now you're just being a twat. Why didn't you spend this energy contributing to the discussion by picking up where I left off and finding out if my assumption was correct? I guess it was easier to attempt to get some dopamine flowing by leveraging yourself into a superior position over someone on the internet.
a better solution for what, i wonder
https://github.com/brave/browser-laptop/commit/c4cd7c1dc41a0...
https://github.com/brave/browser-laptop/commit/6edf56775f256...
https://github.com/brave/browser-laptop/commit/4c30cd08af9dd...
https://github.com/brave/browser-laptop/commit/0652274db0aee...
https://github.com/brave/browser-laptop/commit/c4cd7c1dc41a0...
Also I just realized that is an archived repo that isn't used any more.
I took a quick look through the newer repos and couldn't find any kind of hard coded whitelist like that.
Am I missing something?
It is still whitelisted in current.
https://imgur.com/a/M4B9kJ2
There's a balance between breaking the web and being as strict as possible. Saying we fully allow Facebook tracking isn't right [1], but we admittedly need more strict-mode like settings for privacy conscious users.
We do block Facebook at least as good as uBlock origin with EasyPrivacy. The referenced code is in a separate component which does the same as Disconnect blocking.
We're taking this seriously internally and we'll iterate on where we are to improve the situation. We're looking at if we can polyfill a local JS resource instead for example as one option if it doesn't make further requests.
[1]: https://github.com/brave/adblock-lists/blob/f25b698aff4666bb...
https://github.com/brave/adblock-lists/blob/f25b698aff4666bb...
https://github.com/brave/adblock-lists/blob/f25b698aff4666bb...