I picked out a couple random bits of the sample code to look at. I do have some nitpicks:
- form/checklist: why can't the event handler for toggler just be in the markup? seems like this is done in a few other places. I don't get it.
- form/checklist: it would be nice if the top-level checkbox automatically checked itself if all the children are checked
- form/validation102: using a regex to validate an email is common but still disappointing. at least you handle + in email addresses.
- form/validation102: field names like user[first_name] are odd. I believe these are in fact valid as far as HTML goes, but the only time I've encountered brackets used in field names is with the silly way PHP does arrays.
- form/feedback: when you hit the limit and do the substring substitution to enforce the limit, see if you can move the cursor & scroll state back to what it was before the substitution... right now, the cursor jumps to the end and the scroll is at the top.
2 comments
[ 2.8 ms ] story [ 12.6 ms ] threadEDIT: it seems they mean the book "Prototype and script.aculo.us" - another one of their pragmatic guides.. I think.
- form/checklist: why can't the event handler for toggler just be in the markup? seems like this is done in a few other places. I don't get it.
- form/checklist: it would be nice if the top-level checkbox automatically checked itself if all the children are checked
- form/validation102: using a regex to validate an email is common but still disappointing. at least you handle + in email addresses.
- form/validation102: field names like user[first_name] are odd. I believe these are in fact valid as far as HTML goes, but the only time I've encountered brackets used in field names is with the silly way PHP does arrays.
- form/feedback: when you hit the limit and do the substring substitution to enforce the limit, see if you can move the cursor & scroll state back to what it was before the substitution... right now, the cursor jumps to the end and the scroll is at the top.