Factory Classes – Fail
Pretty much the number 1 thing that could be done to clean up our code base is delete anything with the suffix "factory" in its name.
The number 2 thing, is anything with more than 3 parameters in its constructor is on the edge of being too big.
The number 3 thing, if you can't new up an object in less than 5 seconds, it's too big.
For goodness sake. I have actually found "Factory" classes that have "Factory" classes in their f-bomb constructors.
Any developer currently typing the word "Factory", or considering it, is pretty much coding the anti-pattern of all anti-patterns. I'm willing to debate that assertion, but I will win.
Future pull request reviews - anything with the word "Factory" in it - automatic FAIL. And don't think that "ManufacturingComplex" is going to fool anyone - although it might be a better name for the damn thing.
0 comments
[ 2.8 ms ] story [ 7.5 ms ] threadNo comments yet.