ERP-Application in Python, PyQt5 and PostgreSQL
Download Link: https://github.com/DirkJanJansen/Pandora
ERP Application in PyQt5 and PostgreSQL relational database system.
Python3 powered. Interface: Sqlalchemy-Core.
Modules: Inventory, Sales, Purchase, Manufactory, Employees, Calculation, Accountancy (portal), Payroll administration, Management modules for inventory control and financial control with graphs are included.
For documentation and database structure see Documentation directory.
For instructions, installation and several screenshots see Installation directory.
34 comments
[ 3.0 ms ] story [ 71.5 ms ] threadOne immediate thing I’d do is have a landing page where the screenshots can take center stage and show people what this would look like.
Thanks for the hint
https://github.com/DirkJanJansen/Pandora/blob/master/invoerI... What the heck is this supposed to be? Are you really creating a database table and then a connection, and executing that in the middle of some random code? You really need to separate this out. And this is not a cherrypicked complaint, this is the first file I randomly clicked in the repo.
https://github.com/DirkJanJansen/Pandora/search?q=create_eng... This looks like you're creating a new engine anywhere you need database access. This is NOT how you use SQLAlchemy. Create a database.py file that contains a SINGLE create_engine function, and define all your tables in one place. This code looks like a real mess.
Don't take this as a personal attack. We all had to start somewhere. But this is not something I'd call top quality or really even quality.
If you are so concerned, fork it.
There's a French saying that goes "C'est en forgeant qu'on devient forgeron" (it is by "black-smithing" that one becomes a black-smith).
One way to discover best practices is by putting things out in the open and receiving benevolent feedback on how to do it better.
The code will improve as the author reads more about best practices to apply on a real project they have shared with the comunity, and a benevolent comunity submitting issues and pull requests.
Here's the link to create an issue in that repo:
https://github.com/DirkJanJansen/Pandora/issues/new
Echoing others, I recommend improving the readme and embedding or linking to screenshots in it :)
As a general thought for "making it more presentable", it's probably a good idea to embed a screenshot right into the front page README.
Just from the point of view that "when things look attractive, people are more inclined to check them out".
(Yeah, it's a super generalisation, but it seems to hold true).
As an example, we have a screenshot as nearly the first element people can see:
https://github.com/sqlitebrowser/sqlitebrowser/
Since you already have a bunch of screenshots, it should be fairly simple to make happen.
Maybe these two, as they seem both clean and representative?
https://github.com/DirkJanJansen/Pandora/blob/master/Install...
https://github.com/DirkJanJansen/Pandora/blob/master/Install...
When people need to click on links to see the screenshot(s), it seems like a missed opportunity. ;)
I am trying to build a couple products to figure out which will work and I want to focus on that for the next couple years. But I suffer a lot from procrastination, shift in focus when it comes to own projects.
I checked your commits, really nice that you kept steady since mid-March. If I can do that for my current project, it would be something useful to share with the world.
Thank you :)