Looking for samples of great PR reviews

5 points by zach_miller 5y ago ↗ HN

Hey folks, I want to talk to my coworkers about great pull request reviews. I'd love to see what samples you all might have.

Please share links to any great reviews of PRs, especially if the codebase is open source and I can see everything.

2 comments

[ 573 ms ] story [ 179 ms ] thread

clusmore 5y ago ↗

This isn't what you asked for, but any time I need to explain to somebody what good code review is, I just tell them to watch this video[0]: "Beyond PEP8 - Best practices for beautiful intelligible code" by Raymond Hettinger.

[0]: https://www.youtube.com/watch?v=wf-BqAjZb8M

muffa 5y ago ↗

Here is some documentation about how google does their reviews. I think it is pretty good https://github.com/google/eng-practices/blob/master/review/r...