HN Explorer

HN, review my PR and give a new OSS contributor advice

2 points by anthlax ↗ HN
I’ve never done open source work in my spare time. The only time I’ve contributed to an open source project was for an internship, so I’m not really sure that counts - the guidance was super strong.

I picked out an open source project I liked and found an issue I felt like I could do, and then hacked around until I solved it. I’m looking for advice for improvement be it hygiene, code style, communication style, anything. Help me grow as a soon to be entry level programmer.

https://github.com/Netflix/dgs-framework/pull/1248

Thanks.

4 comments

[ 2.7 ms ] story [ 31.9 ms ] thread
mmastrac
Not being familiar with the project you're working on it looks.. fine? Your communication style is probably a good balance between brevity and detail (avoid using 'lmk', maybe).

You're probably best served finding someone on the project and pinging them for review more than anything.

anthlax
Yeah, they’ll review when they get the chance :). I was talking more general advice. Thanks for taking a look, appreciate it!