[–] tragic95 3y ago ↗ I generally like the idea of keeping PRs small, but it can be difficult to do so, because I'm spending too much time waiting on code reviews. [–] pperi11 3y ago ↗ Stack! [–] fosterfriends 3y ago ↗ ++ to stacking - google has lots of folk's writing on this, ie: https://benjamincongdon.me/blog/2022/07/17/In-Praise-of-Stac...The general idea is that you have a chance to parallelize waiting for review with you writing more code, leading to high-velocity small PRs and never being blocked.
[–] fosterfriends 3y ago ↗ ++ to stacking - google has lots of folk's writing on this, ie: https://benjamincongdon.me/blog/2022/07/17/In-Praise-of-Stac...The general idea is that you have a chance to parallelize waiting for review with you writing more code, leading to high-velocity small PRs and never being blocked.
[–] zuckerborgggg 3y ago ↗ This works fine if you're stacking/using TBDMy team does long-lived feature branches so tbh it's pretty hard to keep PRs small
[–] jacobegold 3y ago ↗ Wait until you see what the research shows about PR descriptions [–] fosterfriends 3y ago ↗ It saddens me so much lol. Im determined to find evidence for writing good descriptions, but hey, all the more interesting if I cant
[–] fosterfriends 3y ago ↗ It saddens me so much lol. Im determined to find evidence for writing good descriptions, but hey, all the more interesting if I cant
7 comments
[ 1.2 ms ] story [ 37.1 ms ] threadThe general idea is that you have a chance to parallelize waiting for review with you writing more code, leading to high-velocity small PRs and never being blocked.
My team does long-lived feature branches so tbh it's pretty hard to keep PRs small