Is this password-generator sufficient?

Wanted to create a very simple password generator. Is it sufficient, or there're some indispensable features missing?

[deleted] 2y ago ↗

(comment deleted)

Also, need feedback around the UI. Is it too simple?

From https://developer.mozilla.org/en-US/docs/Web/JavaScript/Refe...

Math.random() does not provide cryptographically secure random numbers. Do not use them for anything related to security. Use the Web Crypto API instead, and more precisely the window.crypto.getRandomValues() method

aneelkkhatri 2y ago ↗

Interesting!

cratermoon 2y ago ↗

Please, please, if you're going to go into anything related to security, read up on the subject. It's ok to do things like to learn, but putting them into production is unwise. See, for example, https://www.schneier.com/crypto-gram/archives/1998/1015.html... and read up, with books like Applied Cryptography. Read a few DefCon papers or videos.

aneelkkhatri 2y ago ↗

Wow! Thanks for the feedback.

aneelkkhatri 2y ago ↗

I have updated the logic to use window.crypto.getRandomValues(); also made some UI adjustments.

Is this password-generator sufficient? (aneelkkhatri.github.io)

8 comments