I've tried the demos on my iPhone: my only gripe is that when a pop-in is taller than the screen and that I scroll down/up, the whole page scrolls down/up. Is there any way to dissociate scrolling until the pop-in is closed?
This is awesome, but watching the Youtube video is a little problematic on iOS. Users may get lost when you throw them over to the native player. Is there anyway to make it popup in Quicktime instead (like when you try to watch an embedded video) ?
It's so funny, but as I become an exponentially better and better programmer, I start finding myself more and more drawn to stuff like this that someone put together in 2 days and is billed as "light weight" over any other feature than something with a trillion options already built for me.
Whenever a Javscript library throws a ton of inline !important css just to get their shit to look good, I'm like "now what am I supposed to do to make it look how I want it to look? To behave how I want it to behave? STOP IT!"
Maybe it would make things more confusing, but I've never understood why you can't just add extra !'s to !important and make it more important, like a z-index of importance. I can never see it getting very many levels deep, it's only REALLY for using other peoples code and overriding it where you can't get to it.
I strongly suspect that this would, amongst other things, encourage some particularly sloppy library maintainers to ship 'fixes' or indeed first versions with many rules marked with !!!!!!!!!!important, to avoid just this. :/
I completely agree with you. For this exact reason I've made this plugin modular. Which means that you can include only parts that actually use, both from JS part (thanks to Grunt) and from CSS part (thanks to Sass).
This looks really great! Nice work! Do you have a breakdown of why this is better than the other million plugins out there? And I don't mean that in a rude way, either. I just think it would be beneficial for the plugin marketing to explain why it's better (or any other key differences) than others out there! :) Again, great work!
EDIT: I don't know how I originally missed the breakdown of why it's better at the top of the demo page. My apologies! :)
Wow, I feel very ignorant for how quickly I over looked that text on your example page, just to see the demos. Thanks for politely reminding me they were already on there. Doh! Thanks! Keep up the great work! :)
If you couldn’t tell from the omission of indefinite articles in the copy, the author is Russian. He apparently uses Yandex (‘the Russian Google’) analytics, hence the yandex.ru links in the code.
I remember you from your Royal Slider Plugin which is just gorgeous. Your plugins are so much more responsive than other scripts which use too many sluggish transitions. I'm sold on the progressive loading. And I still can't believe you're not charging for this. Or perhaps you're the type that just gets joy from seeing your work all over the internet. In that case, include a donation box.
(Responsive as in "responds quickly"... Is it to late to ask the internet to stop saying Responsive when talking about Adjustive design that scales according to window size or device?)
I like this. I'm using a lot of FancyBox at the moment, but the ability to resize via CSS sounds like a killer feature. And, let's just pretend that the Bootstrap modal doesn't exist.
It's not exactly difficult to find? If you have the attention span of a goldfish, I suppose the time it takes to reach the demo might be a challenge but the typical hn crowd can actually read, unlike most forums :)
That's all reasonable, but unnecessary. In my case, the effort is simply out of order - I don't mind reading, but I always hit the demo first (low effort) to see if the copy is worth reading (higher effort).
So I'm trying to integrate this with my site, and when I enabled gallery mode, I can no longer click to close, or hit the ESC key. Chrome's console seems to show a Uncaught RangeError: Maximum call stack size exceeded in jquery. Ideas?
I'm still trying to isolate it, but it seems that in gallery mode, when mfpClose is fired, it gets into a infinite loop, which causes the stack to overflow, and ultimately cause the page to crash.
I'm using jQuery 1.9.1 and Twitter Bootstrap. On a whim, I looked at your example code and noticed you were using Zepto. I tried switching to Zepto, and this fixed the issue with your gallery, and it closed properly. However, it breaks Bootstrap.
Did you only test with Zepto? There might be an issue in jQuery, where you're selecting elements incorrectly, thus spawning too many events.
> Uncaught RangeError: Maximum call stack size exceeded
Chrome should give you a stack trace for that. Look for patterns: in my experience, that generally shows up when there's a mutual unterminated recursion, e.g. "A calls B, B calls A, A calls B, ..." or "A calls B calls C calls A calls B calls C ...".
67 comments
[ 3.2 ms ] story [ 131 ms ] threadI don't think that it's possible to launch fullscreen YouTube video player in mobile Safari by just clicking on link.
Maybe we should just link directly to the video (not to video page), like so: http://www.youtube.com/embed/PZvi11Yy9r8
This should be tested on real users for a while to see which option is best.
Whenever a Javscript library throws a ton of inline !important css just to get their shit to look good, I'm like "now what am I supposed to do to make it look how I want it to look? To behave how I want it to behave? STOP IT!"
EDIT: I don't know how I originally missed the breakdown of why it's better at the top of the demo page. My apologies! :)
http://dimsemenov.com/plugins/magnific-popup/
Also, be sure to check my article on the Smashing Magazine that explains how this plugin was made - http://coding.smashingmagazine.com/2013/05/02/truly-responsi...
http://www.clicktale.com/
(Responsive as in "responds quickly"... Is it to late to ask the internet to stop saying Responsive when talking about Adjustive design that scales according to window size or device?)
By the way, here is a good discussion related to "responsive" term - http://stackoverflow.com/questions/14831530/responsive-desig...
1: http://dimsemenov.com/plugins/royal-slider/
Thanks for sharing!
I don't care how sweet and lightweight your widget is if it doesn't do what I'm looking for, so put the demo up front!!
At least this one actually has a demo. Sorry for the rant, pet peeve of mine. Otherwise, looks nice.
I'm using jQuery 1.9.1 and Twitter Bootstrap. On a whim, I looked at your example code and noticed you were using Zepto. I tried switching to Zepto, and this fixed the issue with your gallery, and it closed properly. However, it breaks Bootstrap.
Did you only test with Zepto? There might be an issue in jQuery, where you're selecting elements incorrectly, thus spawning too many events.
Chrome should give you a stack trace for that. Look for patterns: in my experience, that generally shows up when there's a mutual unterminated recursion, e.g. "A calls B, B calls A, A calls B, ..." or "A calls B calls C calls A calls B calls C ...".