Show HN: Example implementation of Mozilla's persona and Go server (github.com) 38 points by sauerbraten 13y ago ↗ HN
[–] trebor 13y ago ↗ I didn't realize this, but this is a Persona client library not a Persona server. Not sure why I confused them, but figure it was worth mentioning. [–] sauerbraten 13y ago ↗ Yeah, I worded it differently when I submitted it to /r/golang: Example of using Mozilla's persona with Go
[–] sauerbraten 13y ago ↗ Yeah, I worded it differently when I submitted it to /r/golang: Example of using Mozilla's persona with Go
[–] krf 13y ago ↗ I'm new to Go but shouldn't the defer rawResp.Body.Close() be done after the error checking. If there is an error wouldn't rawResp be nil ? [–] sauerbraten 13y ago ↗ You're right. Fixed it, thanks! [–] realrocker 13y ago ↗ Yup. It should be closed or it will probably leak memory in a few hours. [–] sauerbraten 13y ago ↗ Not really. Memory would only be leaked if there really was an error and rawResp was still nil. Since this usually doesn't happen (at least it never happened to me), you probably wouldn't even have noticed this bug.
[–] realrocker 13y ago ↗ Yup. It should be closed or it will probably leak memory in a few hours. [–] sauerbraten 13y ago ↗ Not really. Memory would only be leaked if there really was an error and rawResp was still nil. Since this usually doesn't happen (at least it never happened to me), you probably wouldn't even have noticed this bug.
[–] sauerbraten 13y ago ↗ Not really. Memory would only be leaked if there really was an error and rawResp was still nil. Since this usually doesn't happen (at least it never happened to me), you probably wouldn't even have noticed this bug.
6 comments
[ 0.21 ms ] story [ 25.9 ms ] thread