Sure. https://github.com/home-assistant/home-assistant/pull/9272 Closed with prejudice as a “hack.” I actually spent some time to make this feature request implementation consistent with other code as another…
Which is sad considering an issue I was attempting to contribute was a bug fix rather than new feature work. Clearly a lot of the earlier code suffers from lack of design. As I mentioned later I have had PRs accepted…
Probably. I had a couple prs accepted by another maintainer fwiw. The code standards were not the issue, nor were unit tests. Not my first rodeo. The later interactions were not pleasant and did not engender much…
Having contributed to a number of projects via github, this is not true at all. I have had prs closed within minutes with curt replies. That is not how you “help newer devs through a PR process.” In another case this…
Sure. https://github.com/home-assistant/home-assistant/pull/9272 Closed with prejudice as a “hack.” I actually spent some time to make this feature request implementation consistent with other code as another…
Which is sad considering an issue I was attempting to contribute was a bug fix rather than new feature work. Clearly a lot of the earlier code suffers from lack of design. As I mentioned later I have had PRs accepted…
Probably. I had a couple prs accepted by another maintainer fwiw. The code standards were not the issue, nor were unit tests. Not my first rodeo. The later interactions were not pleasant and did not engender much…
Having contributed to a number of projects via github, this is not true at all. I have had prs closed within minutes with curt replies. That is not how you “help newer devs through a PR process.” In another case this…